@Frank Mogbuk has joined the channel
#fineract 2026-01-08
As I am Planning more contributions:
1.when refactoring or optimizing an existing method, is it preferred to include the related unit/integration tests in the same PR, or how it should be handled?
Any tips or guidance on best practices for such contributions would be appreciated.
- Optimize methods with advanced Java(streams)
- Add unit/integration tests for the same methods to check its proper working
1.when refactoring or optimizing an existing method, is it preferred to include the related unit/integration tests in the same PR, or how it should be handled?
Any tips or guidance on best practices for such contributions would be appreciated.
yeah, when you improve code, also improve tests for that code if/as necessary
make sure tests are useful, clear, and meaningful
@Adam Saghy and @Victor Romero, A bunch of commits were just pushed on top of a broken build... just checking that you're both aware / in comms about it
the latest one that I have sent is the fix for the "ageing" -> "aging" change https://github.com/apache/fineract/pull/5302 Thank you for the head ups Adam
👍 1
just glancing at https://github.com/apache/fineract/commits/develop/ it looks like E2E shard 2 is consistently failing
I see Java heap space issues... hmm...
ugh, lots of variance in build results for the last ~7 commits