@Aira Jena hi there! Wow, 8 PRs for FINERACT-2171 already? That is a LOT of code. And it looks like the PRs overlap... how are these intended to be merged? This would take me a long time to review. Do we really need so much complexity for this? Who would maintain this code, and how? I'm concerned this is just kind of spiraling out of control. Does any of it run yet? Have you run/tested it?
#fineract 2026-02-06
Hi @Adam Monsen (meonkeys) — quick update on FINERACT-2171: I completed the MVP and consolidated everything into a single PR for review. It fetches messages, renders daily Markdown + indexes, stores cursor state, resolves permalinks, handles user display names and thread replies, plus CI automation and rate‑limit handling. I tested in my personal Slack workspace (auth, fetch, render, cursor), screenshots attached in PR description and can help set up a bot in #C028634A61L or a test channel for validation.
Only 1 PR need to be reviewed and merged: https://github.com/apache/fineract-chat-archive/pull/8
Only 1 PR need to be reviewed and merged: https://github.com/apache/fineract-chat-archive/pull/8
@Aira Jena thank you. I'll close the other PRs. I'd also like your personal opinion on complexity and maintenance. Really I'm trying to gauge if you're going to stick around to maintain this thing, at least until it is stable. And re: maintenance, the patch for PR #8 is 2,000 lines, so I've only skimmed it. I know Java is verbose, it just seems like a lot.
also, please sign all new commits. Apologies, this is a very recently added requirement
I rewrote the commit log messages, excluding the string `FINERACT-2171:` from each. It just takes up space. I'll add it to the commit log message when I merge to main (and I'm going to do a traditional merge, not squash -- I like preserving these incremental commits for posterity).
I have force-pushed your branch, so you'll have to fetch and do a hard reset on your end. Sorry for not warning you first -- I don't plan on doing this often.
If you'd like to add any text to the commit log messages, go right ahead.
I have force-pushed your branch, so you'll have to fetch and do a hard reset on your end. Sorry for not warning you first -- I don't plan on doing this often.
If you'd like to add any text to the commit log messages, go right ahead.
Thanks, @Adam Monsen (meonkeys) — I really appreciate you being candid about complexity and maintenance. To answer directly: yes, I’m committed to maintaining this beyond the MVP. I’m happy to iterate on it, simplify where needed, and gradually add improvements and features as we learn what’s most useful for the community.
👍 1
I agree that ~2,000 lines is non-trivial. My intent for the initial implementation was to be explicit and defensive (especially around rate limiting, allow-listing, and idempotency), but I’m very open to reducing surface area and refactoring as we stabilize the design. If there are areas you feel are over-engineered for MVP, I’m glad to revisit them.
I’ve synced to your force-push and sign all new commits going forward — thanks for the heads-up. Also I have addressed all your comments in the PR and added the detailed guide to create the token.
I’ve synced to your force-push and sign all new commits going forward — thanks for the heads-up. Also I have addressed all your comments in the PR and added the detailed guide to create the token.
🙌 1
it's working! Please see FINERACT-2478 for notes and next steps.