#fineract 2026-03-24

Tue 15:39Adam Monsen (meonkeys)

thoughts on merge commit log messages

reply Tue 15:41Adam Monsen (meonkeys)

By default, when using the green "Merge pull request" button in the GitHub web UI, the log message for the merge commit will look something like this:

Commit message
```Merge pull request #5638 from openMF:FINERACT-2541/owner-to-owner-transfer```
Extended description
```FINERACT-2541: owner to owner transfer functionality```

reply Tue 15:42Adam Monsen (meonkeys)

Which would result in a git commit log message like this:

```Merge pull request #5638 from openMF:FINERACT-2541/owner-to-owner-transfer

FINERACT-2541: owner to owner transfer functionality```

reply Tue 15:42Adam Monsen (meonkeys)

@Adam Saghy @Aleksandar Vidakovic ^ I think that's how it will work.

👀 1

reply Tue 15:44Adam Monsen (meonkeys)

I guess, thinking months/years ahead, if I'm combing through commit log history I'd rather see something like this:

```FINERACT-2541: owner to owner transfer functionality

Merge pull request #5638 from openMF:FINERACT-2541/owner-to-owner-transfer

...more detail here, as much as we want, arbitrary long
...credit/thanks
...other related git commit hashes
...links to mailing list discussions, FSIPs, whatever```
not really a strong preference since the critical backreferences are still present (FINERACT-2541 and PR #5638), but that's just my two cents. I'll likely be `git log`ging only looking at the `develop` branch, so if we want it to look "linear" like it does today, the first line should probably be `FINERACT-2541: owner to owner transfer functionality`

reply Tue 15:46Aleksandar Vidakovic

alright... so I leave the defaults... thanks

reply Tue 15:47James Dailey

is "openMF" here an account ? or remote outside project fork?

reply Tue 15:48Adam Saghy

we were using openMF repository to create the feature branches and raise the PRs to apache repo for simplicity.

reply Tue 15:50Adam Monsen (meonkeys)

yep, that's just the github org where the PR branch lives, James. Git / GitHub track provenance in this manner.

reply Tue 15:50Adam Monsen (meonkeys)

@Aleksandar Vidakovic wrote:
> alright... so I leave the defaults... thanks
I mean, you're welcome to, but that's not what I suggested.

reply Tue 15:51Adam Monsen (meonkeys)

again, not a strong preference either way.

reply Tue 15:51Aleksandar Vidakovic

ok, just needed to know that I'm not doing something that scrambles the Git history you'd like to see 🙂

✅ 1

reply Tue 15:52Aleksandar Vidakovic

... because the first one I merged... was actually the first one since we enforced these new rules... just wasn't sure